PDA

View Full Version : Whose stupid idea was it to refactor my software?



HairyArsedBloke
8th July 2009, 10:41
Some bright spark had the idea on Sunday morning of separating out the library and applications projects from a Visual Studio solution into completely separate solutions, including reorganising the repository, directory structure, namespace conventions, etc.

It sounds a good idea. It is doesn’t make much sense leaving it as it is and it will only cause more problems in the future.

So now it’s nearly lunch time on Wednesday and I still can’t build the whole thing properly.

:tantrum:

When I get my hands on whoever came up with this idea I’m going to sack him.

:spank: :spank: :spank: :spank:

BrilloPad
8th July 2009, 10:43
Some bright spark had the idea on Sunday morning of separating out the library and applications projects from a Visual Studio solution into completely separate solutions, including reorganising the repository, directory structure, namespace conventions, etc.

It sounds a good idea. It is doesn’t make much sense leaving it as it is and it will only cause more problems in the future.

So now it’s nearly lunch time on Wednesday and I still can’t build the whole thing properly.

:tantrum:

When I get my hands on whoever came up with this idea I’m going to sack him.

:spank: :spank: :spank: :spank:

:spel

sh4g

HTH

MPwannadecentincome
8th July 2009, 12:03
Do you use a sourcebase, that should tell you who it was that checked it all back in?

Shimano105
8th July 2009, 12:13
I think the clue is that HAB works by himself.

Simples, all you do is revert back to your previous working version from your source repos - er you do have one... don't you? :eek

HairyArsedBloke
8th July 2009, 12:19
I think the clue is that HAB works by himself.

Simples, all you do is revert back to your previous working version from your source repos - er you do have one... don't you? :eek

:emb

Aye, down to just me at the moment while I'm stuck in the UK. I'm looking forward to building things up later in the year.

bogeyman
8th July 2009, 12:57
:emb

Aye, down to just me at the moment while I'm stuck in the UK. I'm looking forward to building things up later in the year.

I've often done things like that.

Usually as a result of some 'insight' I've had in the period between being asleep and being properly awake.

Up early, full of enthusiasm, 2 minutes in the shower, a nice cup of coffee, and then...

14 hours later: project in pieces, will not build, or if it does, will not work.

16 hours later: restore from previous version, say 'feck it' and go to bed.

It must be the Refactoring Devil, visiting you at night. A bit like the tooth fairy, only worse.

Shimano105
8th July 2009, 13:00
You could try using the built-in VS refactoring tools or even ReSharper in future.

IME using one of the above can help, whereas just ripping out blocks and renaming usually ends in tears.

scotspine
8th July 2009, 13:29
"You could try using the built-in VS refactoring tools or even ReSharper in future."

yep, but even those in the hands of the daring or worse, the half asleep, can quickly and unrelentingly render your lovingly crafted lines of code into the biggest pile of mince you'd never want to see.

just copy everything into notepad hab. it'll be fine you'll see :laugh

HairyArsedBloke
8th July 2009, 13:35
The only code 'changes' that I've made has been to the name spaces. I've moved whole projects between directories and solutions. Then built new assemblies or rather tried to in the higher level cases and I'm getting sheadloads of reference errors.

Nearly done now. I hope.

That'll learn me. :suicide:

OrangeHopper
8th July 2009, 15:04
Be very wary Hairy. If you give up you know that the little imp will come back a little while later, wink at you, and suggest you have another go.

VectraMan
8th July 2009, 15:20
The other week I started on a new version of the Plan B software by hacking it all to pieces, reorganising all the projects, and then spent the next week trying to get a build going again. And that's with loads of stuff missing, and lots of bits #if'd out.

I do quite like doing that sort of major surgery. It helps you reform the bond you had with your code before you became cynical and jaded.:freaky:

MrNoMotivation
8th July 2009, 16:09
Some bright spark had the idea on Sunday morning of separating out the library and applications projects from a Visual Studio solution into completely separate solutions, including reorganising the repository, directory structure, namespace conventions, etc.

It sounds a good idea. It is doesn’t make much sense leaving it as it is and it will only cause more problems in the future.

So now it’s nearly lunch time on Wednesday and I still can’t build the whole thing properly.

:tantrum:

When I get my hands on whoever came up with this idea I’m going to sack him.

:spank: :spank: :spank: :spank:


my point exactly - http://forums.contractoruk.com/general/44218-too-complicated.html

P.S I haven't got a clue what you're talking about

HairyArsedBloke
9th July 2009, 17:44
I've got Bob Shawadiwadi in to give me a hand.

YouTube: Software Configuration Management (http://www.youtube.com/watch?v=q1emeysPZEo)

:throw:

Sysman
9th July 2009, 18:59
I've often done things like that.

Usually as a result of some 'insight' I've had in the period between being asleep and being properly awake.

Up early, full of enthusiasm, 2 minutes in the shower, a nice cup of coffee, and then...

14 hours later: project in pieces, will not build, or if it does, will not work.

16 hours later: restore from previous version, say 'flip it' and go to bed.

It must be the Refactoring Devil, visiting you at night. A bit like the tooth fairy, only worse.

Ooh, I did that with a web site just last week.

Oh well, I did manage to prove my backups work.

minestrone
9th July 2009, 20:41
Refactoring is overrated.

It should be resisted in all ways.

HairyArsedBloke
11th July 2009, 14:18
Finished !

NOW, DON'T DO IT AGAIN
:spank::spank::spank::spank::spank:

I've got another idea, but I think I'll have a bath and then go down the pub instead.

Shimano105
11th July 2009, 14:39
Best idea so far